Skip to content

Comments

Increase default timeout in modal_run_config#362

Closed
msaroufim wants to merge 1 commit intomainfrom
msaroufim-patch-8
Closed

Increase default timeout in modal_run_config#362
msaroufim wants to merge 1 commit intomainfrom
msaroufim-patch-8

Conversation

@msaroufim
Copy link
Member

Increased the default timeout for modal_run_config from 300 to 600 seconds.

Description

Please provide a brief summary of the changes in this pull request.

Checklist

Before submitting this PR, ensure the following steps have been completed:

  • Run the slash command /verifyruns on your own server.
    • Run the cluster bot on your server:
      python discord-bot.py
    • Start training runs with the slash command /verifyruns.
    • Verify that the bot eventually responds with:
      ✅ All runs completed successfully!
      
      (It may take a few minutes for all runs to finish. In particular, the GitHub
      runs may take a little longer. The Modal run is typically quick.)
      For more information on running a cluster bot on your own server, see
      README.md.

Increased the default timeout for modal_run_config from 300 to 600 seconds.
Copilot AI review requested due to automatic review settings September 27, 2025 01:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the default timeout for Modal script execution from 5 minutes to 10 minutes to allow longer-running training operations to complete successfully.

  • Doubled the default timeout value from 300 to 600 seconds in the modal_run_config function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@msaroufim msaroufim closed this Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant